[controls] use shared component for "Values preview" for data control and variable control by nreese · Pull Request #290657 · elastic/kibana

nreese · 2026-09-11T18:03:57Z

PR resolves issue by creating a shared component that is used by both control and variable control editor to ensure both components display same information. Created new package for shared component.

Test instructions

Install sample web logs
Create dashboard
Add variable control with ESQL statement FROM kibana_sample_data_logs | STATS BY machine.os.keyword.
Add control. Click "write a query" and use FROM kibana_sample_data_logs | STATS BY machine.os.keyword
Ensure "Values preview" shows filter pills for each
Try ESQL parse error, set query to not valid. Ensure compile error is displayed
Try query that does not return any values. Set query to FROM kibana_sample_data_logs | where bytes < -1
Try query that returns multiple columns. Set query to FROM kibana_sample_data_logs | STATS BY machine.os.keyword, bytes

infra-vault-gh-plugin-prod · 2026-09-11T18:04:14Z

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

Click to trigger kibana-pull-request for this PR!
Click to trigger kibana-deploy-project-from-pr for this PR!
Click to trigger kibana-deploy-cloud-from-pr for this PR!
Click to trigger kibana-entity-store-performance-from-pr for this PR!
Click to trigger kibana-storybooks-from-pr for this PR!

nreese · 2026-09-11T21:11:22Z

/ci

nreese · 2026-09-11T21:21:35Z

/ci

nreese · 2026-09-11T22:51:49Z

/ci

nreese · 2026-09-14T13:31:09Z

/ci

nreese · 2026-09-14T15:19:07Z

/ci

nreese · 2026-09-14T15:29:28Z

/ci

nreese · 2026-09-14T16:26:49Z

/ci

nreese · 2026-09-14T16:51:22Z

/ci

nreese · 2026-09-14T18:18:19Z

/ci

infra-vault-gh-plugin-prod · 2026-09-14T19:43:17Z

Pinging @elastic/kibana-presentation (Team:Presentation)

akowalska622 · 2026-09-15T08:10:47Z

I didn't check the code yet, but tested locally and seems like I can't run those steps

Try query that does not return any values. Set query to FROM kibana_sample_data_logs | where bytes < -1
Try query that returns multiple columns. Set query to FROM kibana_sample_data_logs | STATS BY machine.os.keyword, bytes

The test instructions don't specify what should be displayed (I'd expect some warnings), but it looks to me like it's stuck on a previous search. Am I doing something wrong while testing or it's a real implementation bug?

Attaching video

Screen.Recording.2026-09-15.at.10.06.53.mov

akowalska622 · 2026-09-15T08:12:33Z

I also see that @stratoula assigned herself to the review, I'll continue testing and review regardless, but I'll leave the final approve for her!

kibanamachine · 2026-09-15T14:09:10Z

💔 Build Failed

Buildkite Build
Commit: 202d1c0
Build duration: 50 mins
Storybooks Preview

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`controls`	133.9KB	133.8KB	-61.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`shared-plugins`	12.2MB	12.1MB	-1.9KB

Unknown metric groups

shared async chunks total size

id	before	after	diff
`all`	15.0MB	15.0MB	+936.0B

total optimizer output size

id	before	after	diff
`all`	63.9MB	63.9MB	-1.1KB

Test Failures

[job] [logs] Jest Tests #14 / ConnectorsForm changes to a new corrector correctly and its fields correctly
[job] [logs] Scout Lane #114 - serverless-observability_complete / default / local-serverless-observability_complete - Synthetics manage rules privilege - lets a read user with can_manage_rules enable default alerting
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - Artifact list page — Blocklist - T1 analyst sees no privileges on the list page
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - Artifact tabs in Policy Details page — Blocklist - ALL user can assign and remove artifacts from the policy
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - Artifact tabs in Policy Details page — Blocklist - ALL user can manage and assign unassigned artifacts
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - Artifact tabs in Policy Details page — Event Filters - ALL user can add an artifact from an empty tab
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - Artifact tabs in Policy Details page — Event Filters - ALL user can manage and assign unassigned artifacts
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - Artifact tabs in Policy Details page — Host isolation exceptions - Tab is hidden when the user has no artifact privilege
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - Artifact tabs in Policy Details page — Trusted applications - Tab is hidden when the user has no artifact privilege
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - Artifact tabs in Policy Details page — Trusted devices - Tab is hidden when the user has no artifact privilege
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - blocked internal saved objects API - post /api/saved_objects/_bulk_create returns 400
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - capabilities - returns a 400 when an invalid app id is provided
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - compression - uses compression when there is no referer
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - global.teardown.ts - Delete leftover agnostic endpoint artifact lists and field-caps seed docs
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - Maps - Full screen mode
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - Painless Lab - runs a script, navigates the panels, and views the request without a11y violations
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - translations - returns the translations with the correct headers
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - ui settings CRUD - returns list of settings
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - ui settings validate - returns validation error for invalid value
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - xsrf protection Authorization-scheme bypass (server.xsrf.allowedSchemes) - accepts a self-invalidation request authenticated with a real ApiKey Authorization header and no kbn-xsrf header
[job] [logs] Scout Lane #130 - serverless-security_complete / default / local-serverless-security_complete - xsrf protection Authorization-scheme bypass (server.xsrf.allowedSchemes) - rejects the same request when authenticated with a cookie session (no Authorization-header scheme), even with the bypass enabled
[job] [logs] Scout Lane #25 - stateful-classic / default / local-stateful-classic - Synthetics manage rules privilege - lets a read user with can_manage_rules enable default alerting

History

💛 Build #501490 was flaky 6b88ce2
💔 Build #501428 failed 0ca01cf
💔 Build #501410 failed a461270
💔 Build #501359 failed ef0c6e3

… does not have one column

nreese · 2026-09-15T15:51:55Z

The test instructions don't specify what should be displayed (I'd expect some warnings), but it looks to me like it's stuck on a previous search. Am I doing something wrong while testing or it's a real implementation bug?

This is an issue with the variables control component not clearing the previous error when the next query does not have one column. Resolved with 2ea14f1

nreese added 2 commits September 11, 2026 11:59

only show range when control type is range slider

e6db812

remove unneeded EuiPanel wrappers

532dd39

nreese added 4 commits September 11, 2026 13:45

move other stuff out of preview_value

e624d6f

move to package

8b82b8f

replace variable preview values with shared component

daaa9a5

only render first 10 values

95ce46a

Changes from node scripts/check

e240bff

nreese added 11 commits September 11, 2026 15:49

fix test

0740469

migrate translations

14c34af

i18n

2c3544b

rename previewOptions to values

4984274

rename previewColumns to columnts

81c5f9f

rename previewError to error

34dc03b

clean up

4a95951

clean up

dbcd015

remove DATA_CONTROL_TYPE

571946b

clean up

0a1f909

remove unused component

4964197

kibanamachine and others added 2 commits September 11, 2026 23:01

Changes from node scripts/check

85d3b49

i18n

10a7abd

nreese added 4 commits September 14, 2026 08:11

use KbnCallout

cb127fe

esql-browser package

fe6f3d1

moon

e3899ad

actionProps

7338eb2

nreese and others added 2 commits September 14, 2026 09:26

clean up

4aeccf7

Merge branch 'main' into issue_274439

ef0c6e3

kibanamachine added 4 commits September 14, 2026 15:37

Changes from node scripts/lint_ts_projects --fix

cb24bb1

Changes from node scripts/generate codeowners

bab6c45

Changes from node scripts/regenerate_moon_projects.js --update

793ed7b

Changes from node scripts/eslint_all_files --no-cache --fix

a461270

i18n

0ca01cf

fix test

6b88ce2

nreese marked this pull request as ready for review September 14, 2026 19:42

nreese requested review from a team as code owners September 14, 2026 19:42

nreese requested review from akowalska622 and nickofthyme September 14, 2026 19:42

nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.6.0 labels Sep 14, 2026

stratoula self-requested a review September 15, 2026 06:36

Merge branch 'main' into issue_274439

202d1c0

fix issue in variable control where error not cleared when next query…

2ea14f1

… does not have one column

Uh oh!

Conversation

nreese commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test instructions

Uh oh!

infra-vault-gh-plugin-prod Bot commented Sep 11, 2026

Uh oh!

nreese commented Sep 11, 2026

Uh oh!

nreese commented Sep 11, 2026

Uh oh!

nreese commented Sep 11, 2026

Uh oh!

nreese commented Sep 14, 2026

Uh oh!

nreese commented Sep 14, 2026

Uh oh!

nreese commented Sep 14, 2026

Uh oh!

nreese commented Sep 14, 2026

Uh oh!

nreese commented Sep 14, 2026

Uh oh!

nreese commented Sep 14, 2026

Uh oh!

infra-vault-gh-plugin-prod Bot commented Sep 14, 2026

Uh oh!

akowalska622 commented Sep 15, 2026

Uh oh!

akowalska622 commented Sep 15, 2026

Uh oh!

kibanamachine commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Page load bundle

shared async chunks total size

total optimizer output size

Test Failures

History

Uh oh!

nreese commented Sep 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nreese commented Sep 11, 2026 •

edited

Loading

kibanamachine commented Sep 15, 2026 •

edited

Loading